zeroshade commented on code in PR #916: URL: https://github.com/apache/arrow-adbc/pull/916#discussion_r1268390236
########## go/adbc/pkg/_tmpl/driver.go.tmpl: ########## @@ -19,7 +19,11 @@ package main -// #cgo CXXFLAGS: -std=c++11 +// ADBC_EXPORTING is required on Windows, or else the symbols +// won't be accessible to the driver manager + +// #cgo CFLAGS: -DADBC_EXPORTING Review Comment: Should we make the ADBC_EXPORTING only get defined on Windows? Or have it defined for all platforms? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
