westonpace commented on code in PR #36517:
URL: https://github.com/apache/arrow/pull/36517#discussion_r1268495406
##########
cpp/src/arrow/flight/client.h:
##########
@@ -301,6 +301,17 @@ class ARROW_FLIGHT_EXPORT FlightClient {
return GetFlightInfo({}, descriptor);
}
+ /// \brief Asynchronous GetFlightInfo.
+ /// \param[in] options Per-RPC options
+ /// \param[in] descriptor the dataset request
+ /// \param[in] listener Callbacks for response and RPC completion
+ void GetFlightInfo(const FlightCallOptions& options, const FlightDescriptor&
descriptor,
+ std::shared_ptr<AsyncListener<FlightInfo>> listener);
+ void GetFlightInfo(const FlightDescriptor& descriptor,
Review Comment:
I don't feel very strongly either way. Some languages have this convention
(e.g. C#) and others do not (e.g. Javascript).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
