R-JunmingChen commented on PR #36739: URL: https://github.com/apache/arrow/pull/36739#issuecomment-1642902140
> Why not improve SetLookupOptions instead to allow selecting the desired semantics? Hi, here are my two considerations: 1. The `null_handling` of all the kernels of `is_in` is `NullHandling::OUTPUT_NOT_NULL`. While a sql-compatible `is_in` can have `NULL` outputs. 2. It's a bit weird to add an option like `sql_compatible` specific for `is_in` in `SetLookupOptions`. Since `SetLookupOptions` is used by `is_in` and `index_in`. But these two considerations are not strict obstacles for using an option instead. For 1, we can set `null_handling` to `NullHandling::COMPUTED_PREALLOCATE` and init the null bitmap to `true` in exec for un-sql-compatible `is_in`. And the new option could be named as `sql_compatible`, which is only used by `is_in`. If you think the solution is ok or have a better solution, I will change code to an new option version soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
