paleolimbot commented on code in PR #262:
URL: https://github.com/apache/arrow-nanoarrow/pull/262#discussion_r1268819408
##########
python/src/nanoarrow/_lib.pyx:
##########
@@ -894,8 +894,11 @@ cdef class ArrayStream:
return array
def __iter__(self):
- while True:
- yield self.get_next()
+ try:
Review Comment:
Thanks! I just looked it up and my head is about to explode but it does
sound cleaner/the thing we should be doing 🤯
##########
python/src/nanoarrow/_lib.pyx:
##########
@@ -894,8 +894,11 @@ cdef class ArrayStream:
return array
def __iter__(self):
- while True:
- yield self.get_next()
+ try:
Review Comment:
Thanks! I just looked it up and my head is about to explode but it does
sound cleaner/the thing we should be doing 🤯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
