izveigor commented on code in PR #6990:
URL: https://github.com/apache/arrow-datafusion/pull/6990#discussion_r1269532717
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -1363,69 +1363,278 @@ pub fn array_ndims(args: &[ArrayRef]) ->
Result<ArrayRef> {
Ok(Arc::new(result) as ArrayRef)
}
-macro_rules! contains {
- ($FIRST_ARRAY:expr, $SECOND_ARRAY:expr, $ARRAY_TYPE:ident) => {{
- let first_array = downcast_arg!($FIRST_ARRAY, $ARRAY_TYPE);
- let second_array = downcast_arg!($SECOND_ARRAY, $ARRAY_TYPE);
- let mut res = true;
- for x in second_array.values().iter().dedup() {
- if !first_array.values().contains(x) {
- res = false;
- break;
+macro_rules! non_list_contains {
+ ($ARRAY:expr, $SUB_ARRAY:expr, $ARRAY_TYPE:ident) => {{
+ let sub_array = downcast_arg!($SUB_ARRAY, $ARRAY_TYPE);
+ let mut boolean_builder = BooleanArray::builder($ARRAY.len());
+
+ for (arr, elem) in $ARRAY.iter().zip(sub_array.iter()) {
+ if let (Some(arr), Some(elem)) = (arr, elem) {
+ let arr = downcast_arg!(arr, $ARRAY_TYPE);
+ let res = arr.iter().dedup().flatten().any(|x| x == elem);
+ boolean_builder.append_value(res);
}
}
+ Ok(Arc::new(boolean_builder.finish()))
+ }};
+}
+
+/// Array_has SQL function
+pub fn array_has(args: &[ArrayRef]) -> Result<ArrayRef> {
+ assert_eq!(args.len(), 2);
+ let array = args[0].as_list::<i32>();
+
+ match args[1].data_type() {
+ DataType::List(_) => {
Review Comment:
👍
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -1363,69 +1363,278 @@ pub fn array_ndims(args: &[ArrayRef]) ->
Result<ArrayRef> {
Ok(Arc::new(result) as ArrayRef)
}
-macro_rules! contains {
- ($FIRST_ARRAY:expr, $SECOND_ARRAY:expr, $ARRAY_TYPE:ident) => {{
- let first_array = downcast_arg!($FIRST_ARRAY, $ARRAY_TYPE);
- let second_array = downcast_arg!($SECOND_ARRAY, $ARRAY_TYPE);
- let mut res = true;
- for x in second_array.values().iter().dedup() {
- if !first_array.values().contains(x) {
- res = false;
- break;
+macro_rules! non_list_contains {
+ ($ARRAY:expr, $SUB_ARRAY:expr, $ARRAY_TYPE:ident) => {{
+ let sub_array = downcast_arg!($SUB_ARRAY, $ARRAY_TYPE);
+ let mut boolean_builder = BooleanArray::builder($ARRAY.len());
+
+ for (arr, elem) in $ARRAY.iter().zip(sub_array.iter()) {
+ if let (Some(arr), Some(elem)) = (arr, elem) {
+ let arr = downcast_arg!(arr, $ARRAY_TYPE);
+ let res = arr.iter().dedup().flatten().any(|x| x == elem);
+ boolean_builder.append_value(res);
}
}
+ Ok(Arc::new(boolean_builder.finish()))
+ }};
+}
+
+/// Array_has SQL function
+pub fn array_has(args: &[ArrayRef]) -> Result<ArrayRef> {
+ assert_eq!(args.len(), 2);
+ let array = args[0].as_list::<i32>();
+
+ match args[1].data_type() {
+ DataType::List(_) => {
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
