tustvold commented on code in PR #7043:
URL: https://github.com/apache/arrow-datafusion/pull/7043#discussion_r1269820180
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -59,181 +56,6 @@ pub(crate) enum ExecutionState {
use super::order::GroupOrdering;
use super::AggregateExec;
-/// An interning store for group keys
-trait GroupValues: Send {
- /// Calculates the `groups` for each input row of `cols`
- fn intern(&mut self, cols: &[ArrayRef], groups: &mut Vec<usize>) ->
Result<()>;
-
- /// Returns the number of bytes used by this [`GroupValues`]
- fn size(&self) -> usize;
-
- /// Returns true if this [`GroupValues`] is empty
- fn is_empty(&self) -> bool;
-
- /// The number of values stored in this [`GroupValues`]
- fn len(&self) -> usize;
-
- /// Emits the group values
- fn emit(&mut self, emit_to: EmitTo) -> Result<Vec<ArrayRef>>;
-}
-
-/// A [`GroupValues`] making use of [`Rows`]
-struct GroupValuesRows {
Review Comment:
This is moved into a new module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
