alamb commented on code in PR #6832:
URL: https://github.com/apache/arrow-datafusion/pull/6832#discussion_r1272516823
##########
datafusion/core/tests/sql/timestamp.rs:
##########
@@ -1035,13 +1035,13 @@ async fn timestamp_sub_with_tz() -> Result<()> {
let sql = "SELECT val, ts1 - ts2 AS ts_diff FROM table_a ORDER BY ts2 -
ts1";
let actual = execute_to_batches(&ctx, sql).await;
let expected = vec![
- "+-----+---------------------------------------------------+",
- "| val | ts_diff |",
- "+-----+---------------------------------------------------+",
- "| 3 | 0 years 0 mons 0 days 10 hours 0 mins 30.000 secs |",
- "| 1 | 0 years 0 mons 0 days 10 hours 0 mins 20.000 secs |",
- "| 2 | 0 years 0 mons 0 days 10 hours 0 mins 10.000 secs |",
- "+-----+---------------------------------------------------+",
+ "+-----+---------+",
+ "| val | ts_diff |",
+ "+-----+---------+",
+ "| 3 | PT30S |",
Review Comment:
I have filed two tickets of interest:
* https://github.com/apache/arrow-datafusion/issues/7068 which tries to
describes the change in semantics this PR does
* https://github.com/apache/arrow-datafusion/issues/7070 that proposes
special casing the display of Duration, based on @waitingkuo 's feedback above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
