smiklos commented on code in PR #4566:
URL: https://github.com/apache/arrow-rs/pull/4566#discussion_r1272631276
##########
arrow-arith/src/boolean.rs:
##########
@@ -312,7 +312,14 @@ pub fn not(left: &BooleanArray) -> Result<BooleanArray,
ArrowError> {
/// ```
pub fn is_null(input: &dyn Array) -> Result<BooleanArray, ArrowError> {
let values = match input.nulls() {
- None => BooleanBuffer::new_unset(input.len()),
+ // NullArray has no nulls buffer yet all values are null
+ None => {
+ if input.data_type().equals_datatype(&DataType::Null) {
Review Comment:
or should we check for input to be NullArray?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
