mustafasrepo commented on code in PR #7083: URL: https://github.com/apache/arrow-datafusion/pull/7083#discussion_r1273353868
########## datafusion/core/tests/sqllogictests/test_files/window.slt: ########## @@ -714,15 +714,27 @@ LIMIT 5 26861 3 -#fn window_frame_ranges_preceding_following -statement error DataFusion error: Internal error: Operator \- is not implemented for types +# fn window_frame_ranges_preceding_following +# when value is outside type range (10000 is outside range of tiny int (type of c2)), +# we should treat values as infinite, hence +# "SUM(c3) OVER(ORDER BY c2 RANGE BETWEEN 10000 PRECEDING AND 10000 FOLLOWING)," +# is functionally equivalent to +# "SUM(c3) OVER(ORDER BY c2 RANGE BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING)," Review Comment: This test supposed to run correctly, I have updated comment to explain how this query supposed to work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
