smiklos commented on code in PR #7088:
URL: https://github.com/apache/arrow-datafusion/pull/7088#discussion_r1273666633
##########
datafusion/core/src/dataframe.rs:
##########
@@ -162,9 +164,10 @@ impl DataFrame {
/// # Ok(())
/// # }
/// ```
- pub fn unnest_column(self, column: &str) -> Result<DataFrame> {
+ /// [Unnest]: crate::logical_expr::Unnest
+ pub fn unnest_column(self, column: &str, preserve_nulls: bool) ->
Result<DataFrame> {
Review Comment:
we could just keep the overload but add the options struct instead of only
the bool flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
