viirya commented on code in PR #7042: URL: https://github.com/apache/arrow-datafusion/pull/7042#discussion_r1273810814
########## docs/source/user-guide/sql/scalar_functions.md: ########## @@ -507,14 +507,17 @@ tanh(numeric_expression) Truncates a number toward zero (at the decimal point). ``` -trunc(numeric_expression) +trunc(numeric_expression[, decimal_places]) ``` #### Arguments - **numeric_expression**: Numeric expression to operate on. Can be a constant, column, or function, and any combination of arithmetic operators. +- **decimal_places**: Optional. The number of decimal places to truncate to. + Defaults to 0. Review Comment: Doc looks good to me. Just one question. Can `decimal_places` be negative? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
