sgilmore10 opened a new pull request, #36873:
URL: https://github.com/apache/arrow/pull/36873
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
There will be many places in the MATLAB interface code base in which we will
have to wrap an `arrow::DataType` object within a subclass of
`arrow::matlab::type::proxy::Type`. To avoid code duplicaiton, we should add a
utility function called `wrap` that accepts a pointer to an `arrow::DataType`
object and returns a pointer to a `arrow::matlab::type::proxy::Type` object.
### What changes are included in this PR?
1. Added a new function with the following signature:
```cpp
arrow::Result<std::shared_ptr<arrow::matlab::type::proxy::Type>> wrap(const
std::shared_ptr<arrow::DataType>& datatype);
```
2. Updated the `type` methods of `arrow::matlab::type::proxy::Field` and
`arrow::matlab::array::proxy::Array` to use `wrap`.
### Are these changes tested?
No new tests needed.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
