jp0317 commented on code in PR #36510:
URL: https://github.com/apache/arrow/pull/36510#discussion_r1274053645
##########
cpp/src/parquet/file_reader.cc:
##########
@@ -66,7 +66,8 @@ static constexpr int64_t kMaxDictHeaderSize = 100;
RowGroupReader::RowGroupReader(std::unique_ptr<Contents> contents)
: contents_(std::move(contents)) {}
-std::shared_ptr<ColumnReader> RowGroupReader::Column(int i) {
+std::shared_ptr<ColumnReader> RowGroupReader::Column(
+ int i, std::optional<ReaderProperties> prop) {
Review Comment:
Thanks for the review. I put all `ColumnReaderProperties` in the
`ReaderProperties` as a shared pointer. Could you please take a look at it?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
