Dandandan commented on a change in pull request #9015:
URL: https://github.com/apache/arrow/pull/9015#discussion_r549035083
##########
File path: rust/benchmarks/src/bin/tpch.rs
##########
@@ -1003,12 +1004,11 @@ async fn execute_query(
if debug {
pretty::print_batches(&result)?;
}
- Ok(())
+ Ok(result)
}
-async fn convert_tbl(opt: ConvertOpt) -> Result<()> {
+async fn convert_tbl(opt: ConvertOpt) ->
Result<Vec<arrow::record_batch::RecordBatch>> {
Review comment:
I would avoid making the type here the same (and return empty vec) to
let it compile. You could change the code in main fn instead to not use the
expression (not generate let binding / returning so the types don't have to be
unified)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
