mustafasrepo commented on code in PR #7040:
URL: https://github.com/apache/arrow-datafusion/pull/7040#discussion_r1275887927
##########
datafusion/common/src/dfschema.rs:
##########
@@ -20,26 +20,315 @@
use std::collections::{HashMap, HashSet};
use std::convert::TryFrom;
+use std::fmt::{Display, Formatter};
use std::hash::Hash;
use std::sync::Arc;
use crate::error::{unqualified_field_not_found, DataFusionError, Result,
SchemaError};
-use crate::{field_not_found, Column, OwnedTableReference, TableReference};
+use crate::{field_not_found, Column, JoinType, OwnedTableReference,
TableReference};
use arrow::compute::can_cast_types;
use arrow::datatypes::{DataType, Field, FieldRef, Fields, Schema, SchemaRef};
-use std::fmt::{Display, Formatter};
/// A reference-counted reference to a `DFSchema`.
pub type DFSchemaRef = Arc<DFSchema>;
+/// This object defines a constraint on a table.
+#[derive(Debug, Clone, PartialEq, Eq, Hash)]
+pub enum Constraint {
+ /// Columns with the given indices form a composite primary key (they are
+ /// jointly unique and not nullable):
+ PrimaryKey(Vec<usize>),
+ /// Columns with the given indices form a composite unique key:
+ Unique(Vec<usize>),
+}
+
Review Comment:
Did this conversion, also doing this change enabled me to use
`primary_key_from_constraints` function as a method of this function. Updated
name is `new_from_table_constraints`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
