Fokko commented on code in PR #36842:
URL: https://github.com/apache/arrow/pull/36842#discussion_r1276123084
##########
python/pyarrow/_dataset.pyx:
##########
@@ -3416,7 +3416,7 @@ cdef class Scanner(_Weakrefable):
fragment to scan.
schema : Schema, optional
The schema of the fragment.
- columns : list of str, default None
+ columns : list of str or dict, default None
Review Comment:
```suggestion
columns : list[str] or dict[str, Expression], default None
```
##########
python/pyarrow/_dataset.pyx:
##########
@@ -3337,7 +3337,7 @@ cdef class Scanner(_Weakrefable):
----------
dataset : Dataset
Dataset to scan.
- columns : list of str, default None
+ columns : list of str or dict, default None
Review Comment:
I also saw `list of str or dict, default None` being used in the document. I
like the `list[str]`
```suggestion
columns : list[str] or dict[str, Expression], default None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
