thisisnic commented on code in PR #36884:
URL: https://github.com/apache/arrow/pull/36884#discussion_r1276869721
##########
r/tools/winlibs.R:
##########
@@ -53,7 +53,7 @@ if
(!file.exists(sprintf("windows/arrow-%s/include/arrow/api.h", VERSION))) {
dev_version <- package_version(VERSION)[1, 4]
# Small dev versions are added for R-only changes during CRAN submission.
- if (is.na(dev_version) || dev_version < 100) {
+ if (is.na(dev_version) || dev_version < "100") {
Review Comment:
Actually, nope, it doesn't matter; because `dev_version` is a
`package_version` object, it's fine (i.e. in this case testing that a dev
version of `10` is higher than the string "2" returns TRUE in the above
comparison when done with the right classes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
