mustafasrepo commented on PR #7124: URL: https://github.com/apache/arrow-datafusion/pull/7124#issuecomment-1655443711
> Hi, @mustafasrepo Where is the variable `orderings` used? I seem to only see updates to it, or maybe I missed something. > > https://github.com/apache/arrow-datafusion/blob/350d4ca8a895a53f51935741ee35e5b79120829c/datafusion/physical-expr/src/aggregate/first_last.rs#L161 `Aggregate::Final` or `Aggregate::FinalPartitioned` can require its ordering according to values inside `orderings`. Hence, these stages can get their values with appropriate ordering. However, I will change the implementation. Hopefully, in the new design, usage of it will be much more explicit. And `merge_batch` implementation will not rely on outside mechanism during merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
