kou commented on code in PR #36929:
URL: https://github.com/apache/arrow/pull/36929#discussion_r1278068475
##########
docs/source/developers/java/building.rst:
##########
@@ -227,6 +223,7 @@ CMake
-DCMAKE_INSTALL_PREFIX=java-dist \
-DCMAKE_UNITY_BUILD=ON
$ cmake --build cpp-jni --target install --config Release
+ $ export
JAVA_JNI_CMAKE_ARGS="-DProtobuf_ROOT=$PWD/cpp-jni/protobuf_ep-install"
Review Comment:
We need to specify this in the following `cmake ...` command line because
`JAVA_JNI_CMAKE_ARGS` is only for `ci/scripts/java_*_build.sh`.
##########
java/pom.xml:
##########
@@ -1145,6 +1149,9 @@
-DCMAKE_INSTALL_LIBDIR=lib/${os.detected.arch}
-DCMAKE_INSTALL_PREFIX=java-dist
-DCMAKE_UNITY_BUILD=ON
+ -DPARQUET_BUILD_EXAMPLES=OFF
+ -DPARQUET_BUILD_EXECUTABLES=OFF
+ -DPARQUET_REQUIRE_ENCRYPTION=OFF
Review Comment:
FYI: They are not harmful but they are redundant because they are `OFF` by
default.
##########
docs/source/developers/java/building.rst:
##########
@@ -272,6 +271,9 @@ CMake
-DCMAKE_INSTALL_LIBDIR=lib/x86_64 ^
-DCMAKE_INSTALL_PREFIX=java-dist ^
-DCMAKE_UNITY_BUILD=ON ^
+ -DPARQUET_BUILD_EXAMPLES=OFF ^
+ -DPARQUET_BUILD_EXECUTABLES=OFF ^
+ -DPARQUET_REQUIRE_ENCRYPTION=OFF ^
Review Comment:
FYI: They are not harmful but they are redundant because they are `OFF` by
default.
##########
java/pom.xml:
##########
@@ -1070,6 +1070,8 @@
-DCMAKE_INSTALL_LIBDIR=lib/${os.detected.arch}
-DCMAKE_INSTALL_PREFIX=${arrow.dataset.jni.dist.dir}
-DCMAKE_PREFIX_PATH=${project.basedir}/../java-dist/lib/${os.detected.arch}/cmake
+ -DProtobuf_USE_STATIC_LIBS=ON
+
-DProtobuf_ROOT=${project.basedir}/../cpp-jni/protobuf_ep-install
Review Comment:
Ah, is this for
https://github.com/apache/arrow/blob/main/java/gandiva/CMakeLists.txt#L41 ?
We can use this solution for now but we should find a better solution that
doesn't require additional CMake options such as `Protobuf_ROOT` and
`Protobuf_USE_STATIC_LIBS`. Could you open an issue for it?
(We may add support for installing bundled `protoc` for this case.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
