tustvold commented on code in PR #4582:
URL: https://github.com/apache/arrow-rs/pull/4582#discussion_r1278318645
##########
arrow-data/src/equal/variable_size.rs:
##########
@@ -59,14 +59,9 @@ pub(super) fn variable_sized_equal<T: ArrowNativeType +
Integer>(
let lhs_values = lhs.buffers()[1].as_slice();
let rhs_values = rhs.buffers()[1].as_slice();
- let lhs_null_count = count_nulls(lhs.nulls(), lhs_start, len);
- let rhs_null_count = count_nulls(rhs.nulls(), rhs_start, len);
-
- if lhs_null_count == 0
- && rhs_null_count == 0
- && !lhs_values.is_empty()
Review Comment:
I'm not sure of the point of this check, as the alternative branch calls
through to the same function regardless...
##########
arrow-data/src/equal/variable_size.rs:
##########
@@ -59,14 +59,9 @@ pub(super) fn variable_sized_equal<T: ArrowNativeType +
Integer>(
let lhs_values = lhs.buffers()[1].as_slice();
let rhs_values = rhs.buffers()[1].as_slice();
- let lhs_null_count = count_nulls(lhs.nulls(), lhs_start, len);
- let rhs_null_count = count_nulls(rhs.nulls(), rhs_start, len);
-
- if lhs_null_count == 0
- && rhs_null_count == 0
- && !lhs_values.is_empty()
Review Comment:
I'm not sure of the point of this check, as the alternative branch calls
through to the same function regardless...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
