tustvold commented on code in PR #6832: URL: https://github.com/apache/arrow-datafusion/pull/6832#discussion_r1278622708
########## datafusion/core/tests/sqllogictests/test_files/decimal.slt: ########## @@ -365,7 +365,7 @@ select c1*c5 from decimal_simple; query T select arrow_typeof(c1/cast(0.00001 as decimal(5,5))) from decimal_simple limit 1; ---- -Decimal128(21, 12) +Decimal128(19, 10) Review Comment: > But this actually changes the precision of decimal arithmetic operations in DataFusion Correct, it changes the semantics of decimal division to match that of postgres, mysql and Hive. I've not done an exhaustive survey of other DBMS products, but the Hive semantics were decided based on a survey of the systems at the time. Other decimal operations are unaffected. This should be definitely communicated, especially if Spark does something different (possibly as a misreading of the Hive specification). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
