izveigor commented on issue #7142: URL: https://github.com/apache/arrow-datafusion/issues/7142#issuecomment-1658242206
@alamb, it looks reasonable for me. But what we would do with pure null arrays (see the ticket: https://github.com/apache/arrow-datafusion/issues/7144). Should it be `ScalarValue::Null` or something else (like `ScalarValue::Int64(None)`)? I also agree that we should check empty arrays by length (`len == 0 -> empty array`) and don't use for these cases `NULL` checking (like the current version DataFusion `array[NULL] -> empty array`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
