alamb commented on code in PR #7129:
URL: https://github.com/apache/arrow-datafusion/pull/7129#discussion_r1279209471
##########
datafusion/core/src/physical_plan/aggregates/order/mod.rs:
##########
@@ -52,7 +52,6 @@ impl GroupOrdering {
} = ordering;
Ok(match mode {
- GroupByOrderMode::None => GroupOrdering::None,
Review Comment:
I got inspired / wanted some excuse to work on the code, so I made
https://github.com/apache/arrow-datafusion/pull/7150 as a potential alternate
approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
