alamb opened a new pull request, #7150: URL: https://github.com/apache/arrow-datafusion/pull/7150
# Which issue does this PR close? Related to https://github.com/apache/arrow-datafusion/pull/7129 # Rationale for this change Inspired by @mustafasrepo 's comment https://github.com/apache/arrow-datafusion/pull/7129/files#r1278576304 about `Option<GroupByOrderMode>` being redundant with `GroupByOrderMode::None` here I tried the alternate approach to see what it would look like I am not sure which I prefer but figured I would put it up for review in case other people liked this # What changes are included in this PR? 1. Change `Option<GroupByOrderMode>` to `GroupByOrderMode` # Are these changes tested? Covered by existing tests # Are there any user-facing changes? No <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
