alamb commented on code in PR #4561:
URL: https://github.com/apache/arrow-rs/pull/4561#discussion_r1280452143
##########
arrow-schema/src/datatype.rs:
##########
@@ -576,6 +576,11 @@ impl DataType {
_ => self == other,
}
}
+
+ /// Create a List DataType default name is "item"
+ pub fn new_list(data_type: DataType, nullable: bool) -> Self {
Review Comment:
> I just think it will be more confusing for users if some APIs specify
"item" and some don't
I don't think it will increase confusion as it is already there: "I am
making a list, what name should I use for its child" when the name never is used
To reduce the confusion I think we should reduce the need for specifying
that field name ever when making lists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
