lidavidm commented on code in PR #951: URL: https://github.com/apache/arrow-adbc/pull/951#discussion_r1280592038
########## c/vendor/portable-snippets/safe-math.h: ########## Review Comment: I think this needs to be added to dev/release/rat_exclude_files.txt, and we need to add a section to the license, e.g. this one: `` The files python/*/*/_version.py and python/*/*/_static_version.py contain code from https://github.com/jbweston/miniver which is made available under the Creative Commons CC0 license. ``` there's instructions on how to do that here: https://github.com/apache/arrow-adbc/blob/main/CONTRIBUTING.md#re-generating-3rd-party-licenses ########## c/vendor/portable-snippets/safe-math.h: ########## Review Comment: I think this needs to be added to dev/release/rat_exclude_files.txt, and we need to add a section to the license, e.g. this one: ``` The files python/*/*/_version.py and python/*/*/_static_version.py contain code from https://github.com/jbweston/miniver which is made available under the Creative Commons CC0 license. ``` there's instructions on how to do that here: https://github.com/apache/arrow-adbc/blob/main/CONTRIBUTING.md#re-generating-3rd-party-licenses -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
