Dandandan commented on a change in pull request #9035:
URL: https://github.com/apache/arrow/pull/9035#discussion_r549490463



##########
File path: rust/datafusion/src/physical_plan/hash_join.rs
##########
@@ -186,8 +190,18 @@ impl ExecutionPlan for HashJoinExec {
                         })
                         .await?;
 
+                    let num_rows: usize =
+                        left_data.1.iter().map(|batch| batch.num_rows()).sum();

Review comment:
       Maybe we want to put this behind a flag so we don't do this in the macro 
so we don't compute the `num_rows` when not being logged?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to