smiklos commented on code in PR #7168:
URL: https://github.com/apache/arrow-datafusion/pull/7168#discussion_r1280705422
##########
datafusion/core/src/physical_plan/unnest.rs:
##########
@@ -133,6 +146,12 @@ impl ExecutionPlan for UnnestExec {
) -> Result<SendableRecordBatchStream> {
let input = self.input.execute(partition, context)?;
+ if self.options.preserve_nulls {
Review Comment:
Preserve_nulls is the default behavior, shouldn't we blow up in case someone
sets it to false?
##########
datafusion/core/src/dataframe.rs:
##########
@@ -151,20 +151,38 @@ impl DataFrame {
/// Expand each list element of a column to multiple rows.
///
+ /// Seee also:
+ ///
+ /// 1. [`UnnestOptions`] documentation for the behavior of `unnest`
+ /// 2. [`Self::unnest_column_with_options`]
+ ///
/// ```
/// # use datafusion::prelude::*;
/// # use datafusion::error::Result;
/// # #[tokio::main]
/// # async fn main() -> Result<()> {
/// let ctx = SessionContext::new();
/// let df = ctx.read_csv("tests/data/example.csv",
CsvReadOptions::new()).await?;
- /// let df = df.unnest_column("a")?;
+ /// let df = df.unnest_column_wtith_optons("a")?;
Review Comment:
typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
