alamb commented on code in PR #7171: URL: https://github.com/apache/arrow-datafusion/pull/7171#discussion_r1281117730
########## datafusion/core/tests/sqllogictests/test_files/math.slt: ########## @@ -93,3 +93,9 @@ query RRRRRRR SELECT atan2(2.0, 1.0), atan2(-2.0, 1.0), atan2(2.0, -1.0), atan2(-2.0, -1.0), atan2(NULL, 1.0), atan2(2.0, NULL), atan2(NULL, NULL); ---- 1.107148717794 -1.107148717794 2.034443935796 -2.034443935796 NULL NULL NULL + +# nanvl +query RRR +SELECT nanvl(asin(10), 1.0), nanvl(1.0, 2.0), nanvl(asin(10), asin(10)) Review Comment: 👍 for testing when both args are NAN ########## datafusion/core/tests/sqllogictests/test_files/math.slt: ########## @@ -93,3 +93,9 @@ query RRRRRRR SELECT atan2(2.0, 1.0), atan2(-2.0, 1.0), atan2(2.0, -1.0), atan2(-2.0, -1.0), atan2(NULL, 1.0), atan2(2.0, NULL), atan2(NULL, NULL); ---- 1.107148717794 -1.107148717794 2.034443935796 -2.034443935796 NULL NULL NULL + +# nanvl +query RRR +SELECT nanvl(asin(10), 1.0), nanvl(1.0, 2.0), nanvl(asin(10), asin(10)) Review Comment: 👍 for testing when both args are NAN -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
