loicalleyne commented on code in PR #36796: URL: https://github.com/apache/arrow/pull/36796#discussion_r1281129390
########## go/arrow/avro/common.go: ########## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package avro + +import ( + "errors" + "fmt" + + "github.com/apache/arrow/go/v13/arrow" + "github.com/apache/arrow/go/v13/arrow/memory" +) + +var ( + ErrMismatchFields = errors.New("arrow/avro: number of records mismatch") +) + +// Option configures an Avro reader/writer. +type Option func(config) +type config interface{} + +// WithTopLevel specifies whether to include an Avro schema's top level record +// or only its fields. +func WithTopLevel(b bool) Option { + return func(cfg config) { + switch cfg := cfg.(type) { + case *OCFReader: + cfg.topLevel = b + default: + panic(fmt.Errorf("arrow/avro: unknown config type %T", cfg)) + } + } +} + +// WithAllocator specifies the Arrow memory allocator used while building records. +func WithAllocator(mem memory.Allocator) Option { + return func(cfg config) { + switch cfg := cfg.(type) { + case *OCFReader: + cfg.mem = mem + default: + panic(fmt.Errorf("arrow/avro: unknown config type %T", cfg)) + } + } +} + +// WithChunk specifies the chunk size used while reading Avro OCF files. +// +// If n is zero or 1, no chunking will take place and the reader will create +// one record per row. +// If n is greater than 1, chunks of n rows will be read. +// If n is negative, the reader will load the whole Avro OCF file into memory and +// create one big record with all the rows. +func WithChunk(n int) Option { + return func(cfg config) { + switch cfg := cfg.(type) { + case *OCFReader: + cfg.chunk = n + default: + panic(fmt.Errorf("arrow/avro: unknown config type %T", cfg)) + } + } +} + +// DefaultNullValues is the set of values considered as NULL values by default +// when Reader is configured to handle NULL values. +var DefaultNullValues = []string{"", "NULL", "null"} Review Comment: this is removed in the latest commit ########## go/arrow/avro/common.go: ########## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package avro + +import ( + "errors" + "fmt" + + "github.com/apache/arrow/go/v13/arrow" + "github.com/apache/arrow/go/v13/arrow/memory" +) + +var ( + ErrMismatchFields = errors.New("arrow/avro: number of records mismatch") +) + +// Option configures an Avro reader/writer. +type Option func(config) +type config interface{} + +// WithTopLevel specifies whether to include an Avro schema's top level record +// or only its fields. +func WithTopLevel(b bool) Option { + return func(cfg config) { + switch cfg := cfg.(type) { + case *OCFReader: + cfg.topLevel = b + default: + panic(fmt.Errorf("arrow/avro: unknown config type %T", cfg)) + } + } +} + +// WithAllocator specifies the Arrow memory allocator used while building records. +func WithAllocator(mem memory.Allocator) Option { + return func(cfg config) { + switch cfg := cfg.(type) { + case *OCFReader: + cfg.mem = mem + default: + panic(fmt.Errorf("arrow/avro: unknown config type %T", cfg)) + } + } +} + +// WithChunk specifies the chunk size used while reading Avro OCF files. +// +// If n is zero or 1, no chunking will take place and the reader will create +// one record per row. +// If n is greater than 1, chunks of n rows will be read. +// If n is negative, the reader will load the whole Avro OCF file into memory and +// create one big record with all the rows. +func WithChunk(n int) Option { + return func(cfg config) { + switch cfg := cfg.(type) { + case *OCFReader: + cfg.chunk = n + default: + panic(fmt.Errorf("arrow/avro: unknown config type %T", cfg)) + } + } +} + +// DefaultNullValues is the set of values considered as NULL values by default +// when Reader is configured to handle NULL values. +var DefaultNullValues = []string{"", "NULL", "null"} + +// WithNullReader sets options for a CSV Reader pertaining to NULL value +// handling. If stringsCanBeNull is true, then a string that matches one of the +// nullValues set will be interpreted as NULL. Numeric columns will be checked +// for nulls in all cases. If no nullValues arguments are passed in, the +// defaults set in NewReader() will be kept. +// +// When no NULL values is given, the default set is taken from DefaultNullValues. +func WithNullReader(stringsCanBeNull bool, nullValues ...string) Option { + return func(cfg config) { + switch cfg := cfg.(type) { + case *OCFReader: + cfg.stringsCanBeNull = stringsCanBeNull + + if len(nullValues) == 0 { + nullValues = DefaultNullValues + } + cfg.nulls = make([]string, len(nullValues)) + copy(cfg.nulls, nullValues) + default: + panic(fmt.Errorf("arrow/avro: unknown config type %T", cfg)) + } + } +} Review Comment: removed in the latest commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
