comphead commented on code in PR #7115:
URL: https://github.com/apache/arrow-datafusion/pull/7115#discussion_r1281139378
##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -2843,16 +2844,16 @@ mod tests {
match expr {
Ok(..) => {
- return Err(DataFusionError::Plan(format!(
+ return plan_err!(
"Builtin scalar function {fun} does not support empty
arguments"
- )));
+ );
}
Err(DataFusionError::Plan(err)) => {
if !err
.contains("No function matches the given name and
argument types")
{
- return Err(DataFusionError::Internal(format!(
- "Builtin scalar function {fun} didn't got the
right error message with empty arguments")));
+ return plan_err!(
Review Comment:
it handles the condition related to
```
Err(DataFusionError::Plan(err))
```
thus its likely more related to plan than to Internal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
