zinking commented on code in PR #36967:
URL: https://github.com/apache/arrow/pull/36967#discussion_r1281317746
##########
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanOptions.java:
##########
@@ -66,6 +76,18 @@ public Optional<String[]> getColumns() {
return columns;
}
+ public Optional<String> getFilter() {
+ return filter;
+ }
+
+ public long getStartOffset() {
Review Comment:
> We may need to implement this for all supported file formats, or throw if
the format does not support splitting.
make sense. I did bear that in mind, so I am having this new newRangeScan
interface to indicate the change, and current behavior wont broke. I'm not
sure I should touch all the format and leave a TODO there? or should I just add
it in the interface (also feels a bit weird). maybe default throw is better.
> does ScanOptions apply to a single input file or total dataset
in my understanding, it applies to a dataset. in that sense it's a bit weird
to specify offset and length. let's see if we have better options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
