not-my-profile commented on code in PR #7177:
URL: https://github.com/apache/arrow-datafusion/pull/7177#discussion_r1281794815


##########
datafusion/core/src/physical_plan/mod.rs:
##########
@@ -55,6 +55,8 @@ pub trait RecordBatchStream: Stream<Item = 
Result<RecordBatch>> {
 }
 
 /// Trait for a [`Stream`] of [`RecordBatch`]es
+///
+/// [`Stream`]: https://docs.rs/futures/latest/futures/stream/trait.Stream.html

Review Comment:
   I think we want to avoid linking `docs.rs` directly ... `datafusion` depends 
on the `futures` crate so we should be able to link the Stream trait with `` 
[`Stream`](futures::stream::Stream) ``.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to