smiklos commented on PR #4626: URL: https://github.com/apache/arrow-rs/pull/4626#issuecomment-1662114644
Looking at it more I think the values array should be always empty if value_length is empty. After all what would we even store there in that case? This is actually validated for in the builder variant but not in `FixedSizeListArray::try_new`. I think the right solution is to add this validation to try_new such that we check that `values.len() = value_length * len`. Then I believe ::value(i) should just blow up if value_length is 0 coz the values array is than empty, and can't be indexed into -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
