tustvold commented on code in PR #4627:
URL: https://github.com/apache/arrow-rs/pull/4627#discussion_r1281843869
##########
arrow-schema/src/field.rs:
##########
@@ -129,6 +129,24 @@ impl Field {
}
}
+ /// Creates a new field suitable for [`DataType::List`] and
+ /// [`DataType::LargeList`]
+ ///
+ /// While not required, by convention the inner `Field` of these
+ /// types is named `"item"`
+ ///
+ /// # Example
+ /// ```
+ /// # use arrow_schema::{Field, DataType};
+ /// assert_eq!(
+ /// Field::new("item", DataType::Int32, true),
+ /// Field::new_list_item(DataType::Int32, true)
Review Comment:
I don't feel strongly, I personally don't see the issue with "item" but
we're going to have to agree to disagree there 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
