alamb commented on code in PR #7179:
URL: https://github.com/apache/arrow-datafusion/pull/7179#discussion_r1283310720
##########
datafusion/core/src/physical_plan/sorts/sort.rs:
##########
@@ -168,7 +288,11 @@ impl ExternalSorter {
!self.spills.is_empty()
}
- /// MergeSort in mem batches as well as spills into total order with
`SortPreservingMergeStream`.
+ /// Returns the final sorted output of all batches inserted via
+ /// [`Self::insert_batch`] as a stream of [`RecordBatch`]es.
+ ///
+ /// This may be an in memory sort/merge if all input fit into memory, or
+ /// a streaming merge from spill files on disk.
Review Comment:
Thanks @yjshen -- I updated the wording in 8d7d08ff0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
