sgilmore10 commented on code in PR #37013:
URL: https://github.com/apache/arrow/pull/37013#discussion_r1283446507
##########
matlab/src/cpp/arrow/matlab/error/error.h:
##########
@@ -173,4 +173,8 @@ namespace arrow::matlab::error {
static const char* UKNOWN_TIME_UNIT_ERROR_ID =
"arrow:matlab:UnknownTimeUnit";
static const char* FIELD_FAILED_TO_CREATE_TYPE_PROXY =
"arrow:field:FailedToCreateTypeProxy";
static const char* ARRAY_FAILED_TO_CREATE_TYPE_PROXY =
"arrow:array:FailedToCreateTypeProxy";
+ static const char* ARROW_TABULAR_SCHEMA_INVALID_NUMERIC_FIELD_INDEX =
"arrow:tabular:schema:InvalidNumericFieldIndex";
+ static const char* ARROW_TABULAR_SCHEMA_INVALID_FIELD_NAME =
"arrow:tabular:schema:InvalidFieldName";
Review Comment:
Could we rename this to `ARROW_TABULSR_SCHEMA_UNKNOWN_FIELD_NAME` to make it
clear this error is about indexing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
