sfc-gh-ebrossard commented on code in PR #37016:
URL: https://github.com/apache/arrow/pull/37016#discussion_r1283668564
##########
cpp/src/parquet/statistics.cc:
##########
@@ -621,7 +628,9 @@ class TypedStatisticsImpl : public TypedStatistics<DType> {
// num_values_ is reliable and it means number of non-null values.
s.all_null_value = num_values_ == 0;
}
- // TODO (GH-36505): distinct count is not encoded for now.
+ if (HasDistinctCount()) {
Review Comment:
@mapleFU FYI I noticed that distinct counts aren't propagated to
`EncodedStatistics`, as tracked in
https://github.com/apache/arrow/issues/36505. For my new test, I could
potentially just check `TypedStatistics` without calling `Encode()`, if you'd
rather that I leave this as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
