Dandandan commented on code in PR #7192:
URL: https://github.com/apache/arrow-datafusion/pull/7192#discussion_r1284069191
##########
datafusion/core/src/physical_plan/aggregates/mod.rs:
##########
@@ -579,6 +585,7 @@ impl AggregateExec {
mut order_by_expr: Vec<Option<LexOrdering>>,
input: Arc<dyn ExecutionPlan>,
input_schema: SchemaRef,
+ limit: Option<usize>,
Review Comment:
Note: limit pushdown could be used even without the sort with min/max to
reduce the final aggregation.
##########
datafusion/core/src/physical_plan/aggregates/mod.rs:
##########
@@ -579,6 +585,7 @@ impl AggregateExec {
mut order_by_expr: Vec<Option<LexOrdering>>,
input: Arc<dyn ExecutionPlan>,
input_schema: SchemaRef,
+ limit: Option<usize>,
Review Comment:
Note: limit pushdown could be used even without the sort with min/max to
reduce the final aggregation output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
