alamb commented on PR #7130: URL: https://github.com/apache/arrow-datafusion/pull/7130#issuecomment-1665373474
I ran the sort benchmarks and they are basically the same. I think the 9% slower measure is due to a high variance in the benchmark (which I should look into if/when I have time). I saw similar variations when I compared `main` to itself ``` ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ alamb_sort-merge-accounting ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩ │ Qsort utf8 │ 60974.35ms │ 66454.87ms │ 1.09x slower │ │ Qsort int │ 78390.32ms │ 82235.04ms │ no change │ │ Qsort │ 66029.57ms │ 65439.66ms │ no change │ │ decimal │ │ │ │ │ Qsort │ 84864.85ms │ 87846.28ms │ no change │ │ integer │ │ │ │ │ tuple │ │ │ │ │ Qsort utf8 │ 62470.81ms │ 63878.11ms │ no change │ │ tuple │ │ │ │ │ Qsort mixed │ 72625.32ms │ 74784.97ms │ no change │ │ tuple │ │ │ │ └──────────────┴────────────┴─────────────────────────────┴──────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
