alamb commented on code in PR #4646:
URL: https://github.com/apache/arrow-rs/pull/4646#discussion_r1284690280
##########
arrow-row/src/interner.rs:
##########
@@ -343,8 +343,19 @@ impl Bucket {
fn size(&self) -> usize {
std::mem::size_of::<Self>()
+ self.slots.capacity() * std::mem::size_of::<Slot>()
+ // and account for the size of any embedded buckets in the slots
+ + self.slot_child_bucket_size()
Review Comment:
The problem is that a `Bucket` may contain other `Bucket`s in the children
`Slots`:
https://github.com/apache/arrow-rs/blob/b15838cfc146b77127660c9ea68eec2816e93a74/arrow-row/src/interner.rs#L233
Their memory was not accounted for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
