kou commented on code in PR #36988: URL: https://github.com/apache/arrow/pull/36988#discussion_r1285474283
########## cpp/src/arrow/filesystem/azurefs_test.cc: ########## @@ -16,6 +16,8 @@ // under the License. #include "arrow/filesystem/azurefs.h" +#include <boost/process.hpp> Review Comment: Could you use https://github.com/apache/arrow/blob/7cbbd3ee95bc0f7d20bb358e2978e2eb18a05304/cpp/src/arrow/filesystem/gcsfs_test.cc#L18-L35 ? ########## cpp/src/arrow/filesystem/azurefs_test.cc: ########## @@ -27,15 +29,76 @@ #include "arrow/testing/util.h" namespace arrow { +using internal::TemporaryDir; namespace fs { namespace { +namespace bp = boost::process; using ::testing::IsEmpty; using ::testing::Not; using ::testing::NotNull; -// Placeholder test for file structure +class AzuriteEnv : public ::testing::Environment { + public: + AzuriteEnv() { + account_name_ = "devstoreaccount1"; + account_key_ = + "Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/" + "KBHBeksoGMGw=="; + auto exe_path = bp::search_path("azurite"); + if (exe_path.empty()) { + auto error = std::string("Could not find Azurite emulator."); + status_ = Status::Invalid(error); + return; + } + auto temp_dir_ = TemporaryDir::Make("azurefs-test-").ValueOrDie(); Review Comment: ```suggestion auto temp_dir_ = *TemporaryDir::Make("azurefs-test-"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
