mbrobbel commented on PR #4653: URL: https://github.com/apache/arrow-rs/pull/4653#issuecomment-1667669541
> > We would have to use [tilde requirements](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#tilde-requirements) to pin to a minor version. > > Unless I am mistaken, cargo will not select a crate version that is not compatible with the selected version of Rust. Therefore if someone is running 1.62 it will select an older version of half to satisfy this. Provided this compiles, which the CI job would indicate it does, we are perfectly correct to state the MSRV as 1.62. This would only change if we were to specify a half version constraint that could not be satisfied by a version compatible with 1.62 Hm I ran into this (after adding `arrow-buffer` as dependency) [here](https://github.com/mbrobbel/narrow/actions/runs/5772132679/job/15646790593#step:5:48): ``` error: package `half v2.3.1` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.65.0 Either upgrade to rustc 1.70 or newer, or use cargo update -p [email protected] --precise ver where `ver` is the latest version of `half` supporting rustc 1.65.0 Error: Process completed with exit code 101. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
