arthurpassos commented on PR #35825: URL: https://github.com/apache/arrow/pull/35825#issuecomment-1667955170
> Thanks for the update but... sorry, I'm going to be negative again. I think it is still a problem that public APIs are exposing hacks or options that are only for internal use (also, the entire use case for this PR is rather niche). > > I would rather if a cleaner approach is chosen (as already suggested some months ago). But if not, I would request that the new publicly-exposed APIs are clearly dissuasive for the user (except the new `ArrowReaderProperties` settings, of course). Details below. I assume this is the [approach](https://github.com/apache/arrow/pull/35825#issuecomment-1602666136) you refer to as already suggested & cleaner. If that's so, can you elaborate on that? I assume I would have to define a `LargeAccumulator` type for each type_trait, that includes: `boolean`, `int32`, `int64` and so on. I can't trick the compiler by doing `using LargeAccumulator = Accumulator;` because that would resolve to the same signature and not a proper overload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
