aiguofer commented on PR #965: URL: https://github.com/apache/arrow-adbc/pull/965#issuecomment-1668348328
That's certainly the biggest issue. The other issue IMO is that generally when I see `**kwargs` in the parameters I think of something I can call like this: `some_function(arg1=value1, arg2=value2, ...)`, but this is a little different since most options have periods, so you HAVE to call it like `some_function(**kwarg_dict)`. To me that feels a little non-standard in Python. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
