alamb commented on code in PR #7230:
URL: https://github.com/apache/arrow-datafusion/pull/7230#discussion_r1287185136
##########
datafusion/core/src/datasource/physical_plan/mod.rs:
##########
@@ -959,7 +959,11 @@ fn get_projected_output_ordering(
// since rest of the orderings are violated
break;
}
- all_orderings.push(new_ordering);
+ // do not push empty entries
+ // otherwise we may have `Some(vec![])` at the output ordering.
Review Comment:
👍
##########
datafusion/core/src/datasource/physical_plan/mod.rs:
##########
@@ -959,7 +959,11 @@ fn get_projected_output_ordering(
// since rest of the orderings are violated
break;
}
- all_orderings.push(new_ordering);
+ // do not push empty entries
+ // otherwise we may have `Some(vec![])` at the output ordering.
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
