jackwener commented on code in PR #7240:
URL: https://github.com/apache/arrow-datafusion/pull/7240#discussion_r1287957313
##########
datafusion/expr/src/aggregate_function.rs:
##########
@@ -25,6 +25,8 @@ use std::{fmt, str::FromStr};
use strum_macros::EnumIter;
/// Enum of all built-in aggregate functions
+// Contributor's guide for adding new aggregate functions
+//
https://arrow.apache.org/datafusion/contributor-guide/index.html#how-to-add-a-new-aggregate-function
Review Comment:
These should be a part of doc instead of code comment
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -34,6 +34,8 @@ use strum_macros::EnumIter;
use lazy_static::lazy_static;
/// Enum of all built-in scalar functions
+// Contributor's guide for adding new scalar functions
+//
https://arrow.apache.org/datafusion/contributor-guide/index.html#how-to-add-a-new-scalar-function
Review Comment:
```suggestion
```
##########
datafusion/expr/src/aggregate_function.rs:
##########
@@ -25,6 +25,8 @@ use std::{fmt, str::FromStr};
use strum_macros::EnumIter;
/// Enum of all built-in aggregate functions
+// Contributor's guide for adding new aggregate functions
+//
https://arrow.apache.org/datafusion/contributor-guide/index.html#how-to-add-a-new-aggregate-function
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
