mapleFU commented on PR #36972: URL: https://github.com/apache/arrow/pull/36972#issuecomment-1670960891
@pitrou I've change the description The previous implemention for `Put(BooleanArray)` regard `sink_.size()` as bits, and reserve less of space for it. Seems that we already uses `PutSpace` and `Put` for Boolean ( see ColumnWriter ). I think it's ok to have a naive implemention for convert `BooleanArray` to `std::vector<bool>` and use `PutImpl` to unify them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
