thisisnic commented on code in PR #36436:
URL: https://github.com/apache/arrow/pull/36436#discussion_r1288289116
##########
r/R/csv.R:
##########
@@ -510,32 +510,55 @@ CsvReadOptions$create <- function(use_threads =
option_use_threads(),
options
}
-readr_to_csv_write_options <- function(include_header = TRUE,
+readr_to_csv_write_options <- function(col_names = TRUE,
batch_size = 1024L,
- na = "") {
+ delim = ",",
+ na = "",
+ eol = "\n",
+ quote = "Needed") {
Review Comment:
This is a tricky one; the aim of supporting the `readr` parameters is so
that folks can use the `arrow` functions as drop-in replacements for their
`readr` etc code, and so it follows that we'd support both the `readr`
parameter names and possible values. For example, we support things like
compact column specification in `read_csv_arrow()` even though Arrow itself
doesn't support this.
It also feels a bit divergent to have parameter values which are using
Pascal Case here as well when everything else is in snake case.
@nealrichardson I'd be keen to get your thoughts here given you were
involved in a lot of the design of the earlier functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
