lidavidm commented on code in PR #37083:
URL: https://github.com/apache/arrow/pull/37083#discussion_r1288419171
##########
java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/ConnectionTest.java:
##########
@@ -102,6 +102,33 @@ public void
testUnencryptedConnectionShouldOpenSuccessfullyWhenProvidedValidCred
}
}
+ /**
+ * Checks if a token is provided it takes precedence over username/pass. In
this case,
+ * the connection should fail if a token is passed in.
+ *
+ * @throws SQLException on error.
+ */
+ @Test(expected = SQLException.class)
Review Comment:
nit: could we use assertThrows to make it clearer where we expect to throw
(and possibly validate the error message too)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
